Re: [PATCH 2/2] refs: support negative transfer.hideRefs

From: Jeff King <peff@peff.net>
Date: Jul 30, 2015, 23:28 UTC
Message-ID: <20150730232835.GA5805@sigill.intra.peff.net>
In-Reply-To: <CAPig+cTJuCWwhzrAt47yCEMv4yrTX-C1e9L_yBwyqJ-YbGfcuA@mail.gmail.com>

On Thu, Jul 30, 2015 at 04:17:35PM -0400, Eric Sunshine wrote:

Show 13 quoted lines

> > +       test_expect_success "Override hiding of $configsection.hiderefs" '
> > +               test_when_finished "test_unconfig $configsection.hiderefs" &&
> > +               git config --add $configsection.hiderefs refs/tags &&
> > +               git config --add $configsection.hiderefs "!refs/tags/magic" &&
> > +               git config --add $configsection.hiderefs refs/tags/magic/one &&
> > +               git ls-remote . >actual &&
> > +               verbose grep refs/tags/magic/two actual
> 
> For completeness, do you also want to add
> 
>     !grep refs/tags/magic/one actual
> 
> to confirm that the third hideRefs did indeed override the second one?

Yeah, I think that is a good change. We could also test_cmp the whole output, but I didn't want to be dependent on other junk from previous tests.

-Peff