kd/

From: Kevin Daudt <me@ikke.info>
Date: Jul 4, 2015, 21:00 UTC
Message-ID: <20150704210032.GB7345@vps892.directvps.nl>
In-Reply-To: <xmqqh9q64a9p.fsf@gitster.dls.corp.google.com>

On Wed, Jun 17, 2015 at 08:36:34AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Kevin Daudt <me@ikke.info> writes:
> 
> > -		require_clean_work_tree "pull with rebase" "Please commit or stash them."
> > +		if [ $(git config --bool --get rebase.autostash || echo false) = false ]
> 
> Style (use of []).

Fixed it.

Show 12 quoted lines

> 
> Shouldn't you be doing
> 
> 	if ...
> 	then        	
> 		on an unborn
> 	elif we are not doing autostash
> 		require clean work tree
> 	fi
> 
> which does not need unnecessarily deep nesting?
>

You are right, much simpler. New patch is underway.