Re: GitHub Pull Request merge commands
- From
Johannes Löthberg <johannes@kyriasis.com>
- Date
- Jun 16, 2015, 09:33 UTC
- Message-ID
- <20150616093345.GA28617@leeloo.kyriasis.com>
- In-Reply-To
- <mloo9l$agl$6@ger.gmane.org>
On 16/06, Florian Lindner wrote:
Show 5 quoted lines
>My question is, if davidsblom make further commits to his develop branch >(after the pull request was issued) aren't these commits also included in >the pull and therefore in the merge? If yes, isn't the idea to merge just >the changes that the pull request was about? If not, why? ;-) >
A pull request is "about" all commits in the branch, which is why topic-branches should be used for PRs.
-- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 https://theos.kyriasis.com/~kyrias/