Re: [GSoC] Week 1: Unification of 'for-each-ref', 'tag -l' and 'branch -l'
- From
Jeff King <peff@peff.net>
- Date
- Jun 3, 2015, 21:08 UTC
- Message-ID
- <20150603210833.GA32181@peff.net>
- In-Reply-To
- <vpqh9qoepv1.fsf@anie.imag.fr>
On Wed, Jun 03, 2015 at 06:08:50PM +0200, Matthieu Moy wrote:
Show 10 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes: > > > Matthieu Moy suggested that I work on the unification of these > > commands let both the implementations stay where the user can select > > the implementation to be used > > Just to be clear: my advice is the above with "user" = "caller of the > API", not "human being using Git". In other words, "git branch > --contains" and "git tag --contains" would still be using two different > algorithms, but the user wouldn't notice (except for performance).
Yeah, I think that is sensible. It should be a "feature" of the ref-filter that can hopefully go away one day (when we have a sensible implementation that works for both; this is something I've been meaning to push forward, but Karthik should not have to wait on me).
-Peff