Re: [PATCH 1/2] config.mak.uname: Darwin: define HAVE_GETDELIM for modern OS X releases

From: Jeff King <peff@peff.net>
Date: Jun 2, 2015, 19:04 UTC
Message-ID: <20150602190403.GA12660@peff.net>
In-Reply-To: <20150602184413.GA11437@peff.net>

On Tue, Jun 02, 2015 at 02:44:13PM -0400, Jeff King wrote:

Show 5 quoted lines

> > +	ifeq ($(shell expr $(shell expr "$(uname_R)" : '\([0-9][0-9]*\)\.') '>=' 11),1)
> 
> Do you need to spawn two shells? It seems like:
> 
>   $(shell expr `expr "$(uname_R)" : '\([0-9][0-9]*\)'` '>=' 11),1)

Oops, I missed the trailing '.' in the regex there, and it probably needs double-quotes in case the inner expr fails to match anything.

We could also use "test -gt" instead of the outer expr, which is more idiomatic shell. But it reports via exit code, so you'd need "&& echo 1" at the end.

-Peff