Re: [PATCH] pack-bitmaps: plug memory leak, fix allocation size for recent_bitmaps

From: Jeff King <peff@peff.net>
Date: May 19, 2015, 02:23 UTC
Message-ID: <20150519022321.GA29026@peff.net>
In-Reply-To: <555A7499.7090900@web.de>

On Tue, May 19, 2015 at 01:24:09AM +0200, René Scharfe wrote:

Show 15 quoted lines

> Use an automatic variable for recent_bitmaps, an array of pointers.
> This way we don't allocate too much and don't have to free the memory
> at the end.  The old code over-allocated because it reserved enough
> memory to store all of the structs it is only pointing to and never
> freed it.  160 64-bit pointers take up 1280 bytes, which is not too
> much to be placed on the stack.
> 
> MAX_XOR_OFFSET is turned into a preprocessor constant to make it
> constant enough for use in an non-variable array declaration.
> 
> Noticed-by: Stefan Beller <stefanbeller@gmail.com>
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> This seems to have fallen through the cracks, or did I just miss it?

Thanks, this looks good.

I looked over the function one more time to make sure it is the function that is wrong, and not my suggestion. :) The current code seems pretty obviously wrong.

-Peff