Re: [PATCH v2] bisect: improve output when bad commit is found

From: Trevor Saunders <tbsaunde@tbsaunde.org>
Date: May 13, 2015, 00:54 UTC
Message-ID: <20150513005432.GF31257@tsaunders-iceball.corp.tor1.mozilla.com>
In-Reply-To: <xmqqwq0dcrcf.fsf@gitster.dls.corp.google.com>

On Tue, May 12, 2015 at 04:24:00PM -0700, Junio C Hamano wrote:

Show 23 quoted lines

> Trevor Saunders <tbsaunde@tbsaunde.org> writes:
> 
> > When the first bad commit has been found git bisect prints something
> > like this:
> >
> > 	<40 char sha1> is the first bad commit
> > 	Commit <40 char sha1>
> > 	...
> >
> > 	:100644 100644 10f5e57... a46cfeb... M  bisect.c
> > 	:100755 100755 ae3fec2... 65a19fa... M  git-bisect.sh
> >
> > The raw diff output is not really useful, and its kind of silly to print
> > the sha1 twice.  Instead lets print something like this:
> >
> > 	The first bad commit is
> > 	Commit <sha1>
> > 	...
> 
> According to +CCouder, this change will break existing people's use
> cases.
> 
> See $gmane/268881

Well, technically he just said it might be that people are parsing the output and could be broken, but if you'd rather not take that risk then I guess we just have to leave things the way they are.

Trev