git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5540: skip under NO_CURL=NoThanks

From
Jeff King <peff@peff.net>
Date
May 6, 2015, 17:32 UTC
Message-ID
<20150506173200.GA7985@peff.net>
In-Reply-To
<xmqq6185d4o1.fsf@gitster.dls.corp.google.com>
On Wed, May 06, 2015 at 09:58:06AM -0700, Junio C Hamano wrote:
> All the other tests in t5xxx series that require http support check
> NO_CURL and skip the test, but this one forgot to do so.

Makes sense, though I wonder if this check should just get pushed into lib-httpd.sh. Surely we can't do anything useful with a web server we started if we have no curl support? And this seems to support the case:

  $ comm -23 <(git grep -l lib-httpd.sh) <(git grep -l NO_CURL)
  lib-httpd.sh
  t5540-http-push-webdav.sh

After your patch, there is literally no script which includes lib-httpd.sh but does not respect NO_CURL.

-Peff
Previous: Junio C HamanoNext: Jeff King
Message 2 of 6 in “t5540: skip under NO_CURL=NoThanks”
  1. t5540: skip under NO_CURL=NoThanksJunio C Hamano, May 6, 2015
  2. Jeff KingMay 6, 2015
  3. Jeff KingMay 6, 2015
  4. Junio C HamanoMay 6, 2015
  5. Junio C HamanoMay 7, 2015
  6. Jeff KingMay 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.