git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] prefix_path(): Unconditionally free result of prefix_path

From
Jeff King <peff@peff.net>
Date
May 5, 2015, 17:56 UTC
Message-ID
<20150505175612.GA9709@peff.net>
In-Reply-To
<xmqqr3qvdizd.fsf@gitster.dls.corp.google.com>
On Tue, May 05, 2015 at 10:36:38AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Stefan Beller <sbeller@google.com> writes:
> 
> >> Should we also squash in these sites? I think they are adequately
> >> covered under the proposed log message.
> >
> > That sounds good to me.
> >>
> >> Found by grepping for prefix_path calls. The only remainders are:
> >>
> >>   1. in blame, we assign the result to a const char that may also point
> >>      straight into to argv, but we never actually free either way
> 
> The return value from add_prefix() that is what prefix_path()
> returned eventually becomes scoreboard.path that needs to be kept
> during the lifetime of the process, and I think there isn't much
> point doing the "free() immediately before exiting".

Yeah, sorry, I meant to say that more explicitly, but clearly didn't. I think it is fine as-is.

> Anyway, here is what I'd queue for now.
Looks good, thanks.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 8 in “prefix_path(): Unconditionally free result of prefix_path”
  1. prefix_path(): Unconditionally free result of prefix_pathStefan Beller, May 4, 2015
  2. Eric SunshineMay 4, 2015
  3. Junio C HamanoMay 4, 2015
  4. Jeff KingMay 5, 2015
  5. Stefan BellerMay 5, 2015
  6. Junio C HamanoMay 5, 2015
  7. Jeff KingMay 5, 2015
  8. Junio C HamanoMay 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.