Re: Bug: git-p4 edit_template() and P4EDITOR w/options

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 4, 2015, 23:11 UTC
Message-ID: <20150504231136.GY5467@google.com>
In-Reply-To: <xmqqvbg8netq.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:

Show 8 quoted lines

>> Perhaps a single-liner patch like this would work?
>>
>> -	system([editor, template_file])
>> +	system(["sh", "-c", editor, template_file])
>
> Nah, scratch that.  The list should be more like
>
> 	["sh", "-c", "%s %s" % (editor, shlex.quote(template_file))]

*nod*

run-command.c does

	system(["sh", "-c", ('%s "$@"' % editor), editor, template_file])

to avoid having to figure out how to shell-quote template_file.