Re: [PATCH] Clarify documentation on commit message strip

From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Apr 27, 2015, 18:13 UTC
Message-ID: <20150427181350.GB15518@paksenarrion.iveqy.com>
In-Reply-To: <xmqqh9s1xytr.fsf@gitster.dls.corp.google.com>

On Mon, Apr 27, 2015 at 10:31:28AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> Fredrik Gustafsson <iveqy@iveqy.com> writes:
> 
> > I agree that it is very clear once you do edit the commit message. My main
> > point with this patch was to clarify -v, since it's not obvious from the
> > documentation that it will be removed.
> 
> While I agree with you that the documentation should make it clear
> that the patch will not be part of the commit, I think the root
> cause of the current "unclear-ness" is because the documentation
> does not make it clear *WHY* the "-v" option gives the patch text
> there.

I agree.

Show 6 quoted lines

> 
> Doing something like this on top of your patch may clarify the
> reason what "-v" is used for, and I suspect that it may even make it
> unnecessary to explicitly say that the patch text will not be part
> of the log message (but I didn't remove that with this "how about
> this" follow-up).

Even better. I would be glad if this could make it into a release. Thanks for the feedback, to make this a good patch.

-- 
Fredrik Gustafsson

phone: +46 733-608274
e-mail: iveqy@iveqy.com
website: http://www.iveqy.com