git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] stop putting argv[0] dirname at front of PATH

From
Jeff King <peff@peff.net>
Date
Apr 22, 2015, 20:00 UTC
Message-ID
<20150422200019.GE27656@peff.net>
In-Reply-To
<20150422192317.GI5467@google.com>
On Wed, Apr 22, 2015 at 12:23:17PM -0700, Jonathan Nieder wrote:
Show 7 quoted lines
> >                                                          And
> > not just for finding binaries; we want to find $(sharedir),
> > etc, the same way.  The RUNTIME_PREFIX build knob does this
> > the right way
> 
> Makes sense.  For the reason you say (templatedir, etc) I am surprised
> to hear that that was the motivation, but I can't find any other.

The Makefile was much less mature, then, so I wondered if maybe those things came later (certainly the munging of $PATH that introduced the problems came later, as at the time we had a special "we are exec-ing a git command" custom version of execvp).

But no, the template directory did indeed exist then. I think it was always a half-baked idea (and got much worse when we stopped putting git-foo into $bindir).

The relevant thread (which I think I linked the other day) is:
  http://article.gmane.org/gmane.comp.version-control.git/16798
-Peff
Previous: Jonathan Nieder
Message 12 of 12 in “PATH modifications for git-hook processes”
  1. Matthew RothenbergApr 14, 2015
  2. Junio C HamanoApr 14, 2015
  3. Matthew RothenbergApr 15, 2015
  4. Jeff KingApr 16, 2015
  5. Jeff KingApr 16, 2015
  6. David RodríguezApr 22, 2015
  7. Junio C HamanoApr 22, 2015
  8. stop putting argv[0] dirname at front of PATHJeff King, Apr 22, 2015
  9. Eric SunshineApr 22, 2015
  10. Jeff KingApr 22, 2015
  11. Jonathan NiederApr 22, 2015
  12. Jeff KingApr 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.