Re: [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type
- From
Jeff King <peff@peff.net>
- Date
- Apr 17, 2015, 18:49 UTC
- Message-ID
- <20150417184939.GA32578@peff.net>
- In-Reply-To
- <553154C8.5090001@gmail.com>
On Sat, Apr 18, 2015 at 12:15:28AM +0530, karthik nayak wrote:
Show 8 quoted lines
> >But now we use type_from_string_gently, which can accept a length[1]. So > >we could just count the bytes to the first space and pass the original > >buffer along with that length, no? > > Yes, we could, that would eliminate "struct strbuf typename = > STRBUF_INIT". > > Something like this perhaps :
Yeah, this is exactly what I had in mind.
Show 6 quoted lines
> {
> - char type[10];
> - int i;
> + const char *buf = hdr;
> unsigned long size;
> + int type, len = 0;Maybe switch the names of "buf" and "len" to "type_buf" and "type_len" to make their purpose more clear?
-Peff