Re: [PATCH] Fix settings in default_user_config template

From: Jeff King <peff@peff.net>
Date: Apr 17, 2015, 14:55 UTC
Message-ID: <20150417145516.GB2421@peff.net>
In-Reply-To: <1429282210-38538-1-git-send-email-oherrala@gmail.com>

On Fri, Apr 17, 2015 at 05:50:10PM +0300, Ossi Herrala wrote:

> The name (not user) and email setting should be in config section
> "user" and not in "core" as documented in Documentation/config.txt.

<facepalm> Well, those probably weren't helping any new users, then, were they? :)

Show 14 quoted lines

> diff --git a/builtin/config.c b/builtin/config.c
> index d32c532..bfd3016 100644
> --- a/builtin/config.c
> +++ b/builtin/config.c
> @@ -455,9 +455,9 @@ static char *default_user_config(void)
>  	struct strbuf buf = STRBUF_INIT;
>  	strbuf_addf(&buf,
>  		    _("# This is Git's per-user configuration file.\n"
> -		      "[core]\n"
> +		      "[user]\n"
>  		      "# Please adapt and uncomment the following lines:\n"
> -		      "#	user = %s\n"
> +		      "#	name = %s\n"
>  		      "#	email = %s\n"),

Looks obviously correct. Thanks for noticing.

-Peff