Re: Issue: repack semi-frequently fails on Windows (msysgit) - suspecting file descriptor issues
- From
- Andreas Mohr <andi@lisas.de>
- Date
- Apr 16, 2015, 20:56 UTC
- Message-ID
- <20150416205658.GB20385@rhlx01.hs-esslingen.de>
- In-Reply-To
- <a710472d7bf37757b7341dd99f8c76f3@www.dscho.org>
[git-owner CC dutifully removed]
On Thu, Apr 16, 2015 at 05:48:42PM +0200, Johannes Schindelin wrote:
Show 16 quoted lines
> Hi Peff, > > On 2015-04-16 17:28, Jeff King wrote: > > On Thu, Apr 16, 2015 at 01:35:05PM +0200, Andreas Mohr wrote: > > > >> I strongly suspect that git's repacking implementation > >> (probably unrelated to msysgit-specific deviations, > >> IOW, git *core* handling) > >> simply is buggy > >> in that it may keep certain file descriptors open > >> at least a certain time (depending on scope of implementation/objects!?) > >> beyond having finished its operation (rename?). > > > > Hrm. [... detailed analysis, including a Minimal, Complete & Verifiable Example ...] > > Thank you so much! I will definitely test this (at the moment, I have to recreate my build environment in a different VM than I used so far, that takes quite some time...)
Your hash-object script successfully and with ease managed to provoke the issue again, thanks a lot! (syntax issue though: missed a '|' pipe).
And I then did some unload tests (force-unloaded, via End Process Tree) of the virus, and the unlink issue persisted (but to be truly certain, I would have to rename away the entire virus installation tree). Not to mention that it already looks anyway like we seem to be on the way of nailing a genuine git handling bug...
Also, I have a very hard time remembering that the "retry unlink?" EVER finally ended up successful (despite virus file activity surely being a very temporary thing!).
So much for some "related" observations that I can contribute currently - I had no time left to actually work on it today but I'll try to do some testing given the very detailed (and gratifyingly matching :) analysis of Jeff King (thanks a lot, too!).
Andreas Mohr
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.