Re: git clean performance issues
- From
Jeff King <peff@peff.net>
- Date
- Apr 4, 2015, 20:48 UTC
- Message-ID
- <20150404204802.GA558@peff.net>
- In-Reply-To
- <CAMpP7NZ8OD5or8H11OvuH1nq+qe-btKCsQnhas6+7SRYE1M1Tw@mail.gmail.com>
On Sat, Apr 04, 2015 at 10:39:47PM +0200, erik elfström wrote:
Show 5 quoted lines
> That looks like the same issue. The "use is_git_directory" approach > sounds good to me, is that the direction you would prefer? I can try > to cobble something together although I must warn you I have zero > previous experience with this code base so a few iterations will > probably be needed.
Yeah, I think the preferred direction is building a solution in is_git_directory. Multiple iterations are fine. That's what review is for. :) See SubmittingPatches for tips, though.
-Peff