git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] enter_repo(): fix docs to match code

From
Jeff King <peff@peff.net>
Date
Mar 31, 2015, 17:41 UTC
Message-ID
<20150331174141.GG18912@peff.net>
In-Reply-To
<xmqq4mp1rrwj.fsf@gitster.dls.corp.google.com>
On Tue, Mar 31, 2015 at 10:35:56AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> > In b3256eb (standardize and improve lookup rules for external local
> > repos), enter_repo() was modified to use a different precedence ordering
> > of suffixes for DWIM of the repository path, and to ensure that the
> > repository path is actually valid instead of just testing for existence.
> > However, the documentation was not modified to reflect these changes.
> > As such, fix the documentation to match the code.
> >
> > Documentation contributed by Jeff King.
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > Signed-off-by: Paul Tan <pyokagan@gmail.com>
> > ---
> 
> It appears to me that Peff's "squash" is nullifying everything you
> did, so a more truthful attribution might be

I'm not sure that's true. The precedence changed, and the "is it valid" check changed. The fix for the first is from Paul, but the latter is from me. My squash (hopefully) retained his half. My half just took more words to change.

I'm OK with the attribution either way (I do not need the credit, but am happy to take the blame).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 8 in “enter_repo(): fix suffix precedence documentation”
  1. enter_repo(): fix suffix precedence documentationPaul Tan, Mar 30, 2015
  2. Matthieu MoyMar 30, 2015
  3. enter_repo(): fix docs to match codePaul Tan, Mar 31, 2015
  4. Junio C HamanoMar 31, 2015
  5. Jeff KingMar 31, 2015
  6. Junio C HamanoMar 31, 2015
  7. enter_repo(): fix docs to match codePaul Tan, Mar 31, 2015
  8. Jeff KingMar 30, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.