[PATCH 1/6] remote.c: drop default_remote_name variable
- From
Jeff King <peff@peff.net>
- Date
- Mar 31, 2015, 17:34 UTC
- Message-ID
- <20150331173437.GA18912@peff.net>
- In-Reply-To
- <20150331173339.GA17732@peff.net>
When we read the remote config from disk, we update a default_remote_name variable if we see branch.*.remote config for the current branch. This isn't wrong, or even all that complicated, but it is a bit simpler (because it reduces our overall state) to just lazily compute the default when we need it.
The ulterior motive here is that the push config uses a similar structure, and _is_ much more complicated as a result. That will be simplified in a future patch, and it's more readable if the logic remotes and push-remotes matches.
Note that we also used default_remote_name as a signal that the remote config has been loaded; after this patch, we now use an explicit flag.
Signed-off-by: Jeff King <peff@peff.net> --- remote.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/remote.c b/remote.c index 68901b0..fcd868d 100644 --- a/remote.c +++ b/remote.c @@ -39,6 +39,8 @@ struct rewrites { int rewrite_nr; }; +static int loaded_remotes_config; + static struct remote **remotes; static int remotes_alloc; static int remotes_nr; @@ -49,10 +51,8 @@ static int branches_alloc; static int branches_nr; static struct branch *current_branch; -static const char *default_remote_name; static const char *branch_pushremote_name; static const char *pushremote_name; -static int explicit_default_remote_name; static struct rewrites rewrites; static struct rewrites rewrites_push; @@ -367,12 +367,7 @@ static int handle_config(const char *key, const char *value, void *cb) return 0; branch = make_branch(name, subkey - name); if (!strcmp(subkey, ".remote")) { - if (git_config_string(&branch->remote_name, key, value)) - return -1; - if (branch == current_branch) { - default_remote_name = branch->remote_name; - explicit_default_remote_name = 1; - } + return git_config_string(&branch->remote_name, key, value); } else if (!strcmp(subkey, ".pushremote")) { if (branch == current_branch) if (git_config_string(&branch_pushremote_name, key, value)) @@ -504,9 +499,11 @@ static void read_config(void) unsigned char sha1[20]; const char *head_ref; int flag; - if (default_remote_name) /* did this already */ + + if (loaded_remotes_config) return; - default_remote_name = "origin"; + loaded_remotes_config = 1; + current_branch = NULL; head_ref = resolve_ref_unsafe("HEAD", 0, sha1, &flag); if (head_ref && (flag & REF_ISSYMREF) && @@ -708,8 +705,11 @@ static struct remote *remote_get_1(const char *name, const char *pushremote_name name = pushremote_name; name_given = 1; } else { - name = default_remote_name; - name_given = explicit_default_remote_name; + if (current_branch && current_branch->remote_name) { + name = current_branch->remote_name; + name_given = 1; + } else + name = "origin"; } }
-- 2.4.0.rc0.363.gf9f328b