Re: [PATCHv3 5/6] pack-bitmap.c: fix a memleak

From: Jeff King <peff@peff.net>
Date: Mar 31, 2015, 03:32 UTC
Message-ID: <20150331033202.GB842@peff.net>
In-Reply-To: <1427764931-27745-6-git-send-email-sbeller@google.com>

On Mon, Mar 30, 2015 at 06:22:10PM -0700, Stefan Beller wrote:

Show 15 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  pack-bitmap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/pack-bitmap.c b/pack-bitmap.c
> index 365f9d9..62a98cc 100644
> --- a/pack-bitmap.c
> +++ b/pack-bitmap.c
> @@ -986,6 +986,8 @@ void test_bitmap_walk(struct rev_info *revs)
>  		fprintf(stderr, "OK!\n");
>  	else
>  		fprintf(stderr, "Mismatch!\n");
> +
> +	free(result);

I think this one is fine. I see you dropped the other bits from load_bitmap_entries_v1. There are definitely some leaks there in the error case, and I left some notes in the other thread.

I don't think those leaks are all that critical (we only load the bitmaps one per process, and the memory persists if we succeed, so the worst case is that we spend the memory but do not get to use the bitmaps). But if your goal is making us valgrind-clean, they would certainly count.

-Peff