git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH, RFC] checkout: Attempt to checkout submodules

From
TSTrevor Saunders <tbsaunde@tbsaunde.org>
Date
Mar 20, 2015, 00:13 UTC
Message-ID
<20150320001345.GC21536@tsaunders-iceball.corp.tor1.mozilla.com>
In-Reply-To
<xmqq3850it94.fsf@gitster.dls.corp.google.com>
On Thu, Mar 19, 2015 at 02:15:19PM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> Trevor Saunders <tbsaunde@tbsaunde.org> writes:
> 
> > On one hand it seems kind of user hostile to just toss out any changes
> > in the submodule that are uncommitted, on the other for any other path
> > it would seem weird to have git checkout trigger rebasing or merging.
> 
> I think that is exactly why we do not do anything in this codepath.

yeah, and not only is it weird, but git diff will still report that there's a difference which I imagine people will find strange.

> I have a feeling that an optional feature that allows "git submodule
> update" to happen automatically from this codepath might be
> acceptable by the submodule folks, and they might even say it does
> not even have to be optional but should be enabled by default.

ok, that seems fairly reasonable. I do kind of wonder though if it shouldn't be 'git submodule update --checkout' but that would get us kind of back to where we started. I guess since the default is checkout if you set the pref then you can be assumed to have some amount of idea what your doing.

> But I do not think it would fly well to unconditionally run
> "checkout -f" here.
agreed
Trev
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous: Junio C HamanoNext: Jens Lehmann
Message 5 of 8 in “checkout: Attempt to checkout submodules”
  1. checkout: Attempt to checkout submodulesTrevor Saunders, Mar 18, 2015
  2. Junio C HamanoMar 19, 2015
  3. Trevor SaundersMar 19, 2015
  4. Junio C HamanoMar 19, 2015
  5. Trevor SaundersMar 20, 2015
  6. Jens LehmannMar 23, 2015
  7. Trevor SaundersMar 24, 2015
  8. Jens LehmannMar 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.