Re: [PATCH] git=p4.py rebase now honor's client spec

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 19, 2015, 21:58 UTC
Message-ID: <20150319215816.GI612775@vauxhall.crustytoothpaste.net>
In-Reply-To: <D1303946.5CED%Sam.Bishop@blackboard.com>

On Thu, Mar 19, 2015 at 12:28:09PM +0000, Sam Bishop wrote:

Show 13 quoted lines

> When using the git-p4.py script, I found that if I used a client spec when
> cloning out a perforce repository, and then using a git-p4.py rebase, that
> the rebase command would be using the current perforce client spec,
> instead of the one used when doing the initial clone. My proposed patch
> causes the rebase command to switch to the perforce client spec used when
> doing the initial git-p4.py clone.
> 
> This email and any attachments may contain confidential and
> proprietary information of Blackboard that is for the sole use of the
> intended recipient. If you are not the intended recipient, disclosure,
> copying, re-distribution or other use of any of this information is
> strictly prohibited. Please immediately notify the sender and delete
> this transmission if you received this email in error.

You might want to read Documentation/SubmittingPatches for information on patch submission procedures. Most notably, you'll need to sign-off your work to indicate that you can submit it under the appropriate license.

The confidentiality notice above is not only inappropriate for a public mailing list, it discourages people from even looking at your patch, as you just claimed it was confidential and proprietary and nobody wants to be sued.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187