Re: [RFC] git submodule purge

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 17, 2015, 07:56 UTC
Message-ID: <20150317075636.GA354@pks-pc>
In-Reply-To: <20150316200353.GB5186@google.com>

On Mon, Mar 16, 2015 at 01:03:53PM -0700, Jonathan Nieder wrote:

Show 55 quoted lines

> (+cc: Jens and Heiko, submodule experts)
> Hi,
> 
> Patrick Steinhardt wrote:
> 
> > This proposal is just for discussion. If there is any interest I
> > will implement the feature and send some patches.
> >
> > Currently it is hard to properly remove submodules. That is when
> > a submodule is deinitialized and removed from a repository the
> > directory '.git/modules/<SM_NAME>' will still be present and
> > there is no way to remove it despite manually calling `rm` on it.
> > I think there should be a command that is able to remove those
> > dangling repositories if the following conditions are met:
> >
> > - the submodule should not be initialized
> >
> > - the submodule should not have an entry in .gitmodules in the
> >   currently checked out revision
> >
> > - the submodule should not contain any commits that are not
> >   upstream
> >
> > - the submodule should not contain other submodules that do not
> >   meet those conditions
> >
> > This would ensure that it is hard to loose any commits that may
> > be of interest. In the case that the user knows what he is doing
> > we may provide a '--force' switch to override those checks.
> 
> Those conditions look simultaneously too strong and too weak. ;-)
> 
> In principle, it should be safe to remove .git/modules/<name> as
> long as
> 
>  (1) it (and its submodules, sub-sub-modules, etc) doesn't have any
>      un-pushed local commits.
> 
>  (2) it is not being referred to by a .git file in the work tree of
>      the parent repository.
> 
> Condition (1) can be relaxed if the user knows what they are losing
> and is okay with that.  Condition (2) can be avoided by removing
> (de-initing) the copy of that submodule in the worktree at the same
> time.
> 
> The functionality sounds like a useful thing to have, whether as an
> option to 'git submodule deinit' or as a new subcommand.  In the long
> term I would like it to be possible to do everything 'git submodule'
> can do using normal git commands instead of that specialized
> interface.  What command do you think this would eventually belong in?
> (An option to "git gc", maybe?)
> 
> Thanks,
> Jonathan

Thanks for your feedback.

Considering that purging the submodule is tightly coupled with de-initializing it, it might make sense to provide this functionality as part of `git submodule deinit`. Maybe something like `git submodule deinit --purge` would work for the user. Problem is if the user first removes the submodule and does not first deinitialize it he is not able to purge the repository afterwards as deinit will complain about the submodule not being matched anymore. We could just make `deinit --purge` work with removed submodules, but that does not feel very natural to me.

`git gc` feels saner in that regard, but I don't think it would be easy to spot for users as this command is in general not used very frequently by them. One could argue though that it does not need to be discoverable.

Regards Patrick