git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH v2] log: forbid log --graph --no-walk

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Mar 15, 2015, 00:04 UTC
Message-ID
<20150315000440.GB612775@vauxhall.crustytoothpaste.net>
In-Reply-To
<5504CA70.2030602@norn.io>
On Sun, Mar 15, 2015 at 01:55:28AM +0200, epilys wrote:
Show 6 quoted lines
> On 03/15/2015 01:47 AM, brian m. carlson wrote:
> > It looks like you indented here with four spaces instead of a tab. 
> > We prefer tabs in Git.
> 
> Messed that up. Do you think I should resubmit a v3 or am I hogging
> the mailing list too much?

You're going to want to submit a v3. While you're at it, you probably want to drop the [GSoC] from the patch header, as it will be part of the commit message when applied, and we don't want that. Finally, you probably want to use your full name in the From: line, as that will be used to create the commit, and we prefer full names over aliases as well.

It can be helpful to try formatting the patch with git format-patch and then checking over it with less and applying it with git am to see how it will look to other Git developers.

This is a small patch, so it's not as big a deal, but for larger series I generally try to wait two or three days (at least one of which is a weekday) before posting a new version so that people have time to read, test, and comment on it.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: epilys
Message 4 of 4 in “log: forbid log --graph --no-walk”
  1. epilysMar 14, 2015
  2. brian m. carlsonMar 14, 2015
  3. epilysMar 14, 2015
  4. brian m. carlsonMar 15, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.