git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] fix transfer.hiderefs with smart http

From
Jeff King <peff@peff.net>
Date
Mar 13, 2015, 04:59 UTC
Message-ID
<20150313045952.GA18853@peff.net>
In-Reply-To
<20150313044101.GA18476@peff.net>
On Fri, Mar 13, 2015 at 12:41:01AM -0400, Jeff King wrote:
> I'm experimenting with using transfer.hiderefs on a server, and it's
> rather easy to cause a git client to hang when fetching from such a repo
> over smart http. Details are in the first patch.

A note on this hang. What happens is that upload-pack sees a bogus "want" line and calls die(). The client then sits there forever, but I'm not exactly sure what it's waiting for.

This series fixes the bug that caused us to erroneously call die() in upload-pack, so the hang is "fixed". But there are other reasons to call die(); it would probably be a good thing if the client side noticed the problem and aborted.

-Peff
Previous: Jeff KingNext: Duy Nguyen
Message 11 of 12 in “fix transfer.hiderefs with smart http”
  1. 0/7 fix transfer.hiderefs with smart httpJeff King, Mar 13, 2015
  2. 1/7 upload-pack: fix transfer.hiderefs over smart-httpJeff King, Mar 13, 2015
  3. Junio C HamanoMar 13, 2015
  4. 2/7 upload-pack: do not check NULL return of lookup_unknown_objectJeff King, Mar 13, 2015
  5. 3/7 t: translate SIGINT to an exitJeff King, Mar 13, 2015
  6. 4/7 t: redirect stderr GIT_TRACE to descriptor 4Jeff King, Mar 13, 2015
  7. 5/7 t: pass GIT_TRACE through ApacheJeff King, Mar 13, 2015
  8. 6/7 t5541: move run_with_cmdline_limit to test-lib.shJeff King, Mar 13, 2015
  9. Eric SunshineMar 13, 2015
  10. 7/7 t5551: make EXPENSIVE test cheaperJeff King, Mar 13, 2015
  11. Jeff KingMar 13, 2015
  12. Duy NguyenMar 13, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.