Re: Deadlock during remote update

From: Jeff King <peff@peff.net>
Date: Feb 27, 2015, 13:21 UTC
Message-ID: <20150227132113.GB13005@peff.net>
In-Reply-To: <CACsJy8AG9ZdhZj_pAb3sZPntBt+GPLj06dXDAV=w+5HyL6D+0Q@mail.gmail.com>

On Fri, Feb 27, 2015 at 06:27:28PM +0700, Duy Nguyen wrote:

Show 13 quoted lines

> > 31638 git-remote-https upstream https://git.openstack.org/openstack/nova
> >     has pipe:[170381707] (fd 1), waiting for read from pipe:[170384472]
> > 31642 git fetch-pack --stateless-rpc --lock-pack --include-tag --thin --no-progress https://git.openstack.org/openstack/nova/  efs/heads/master
> >     has pipe:[170384472] (fd 1), waiting for read from pipe:[170384471] (fd 0) which fd 7 on 31638
> >
> > 31638 and 31642 are both waiting to read from a pipe that the other has, and isn't writing to.
> >
> > This is git version 1.7.9.5, OS is ubuntu precise.
> 
> There's this commit 2a45520 (remote-curl: always parse incoming refs -
> 2013-02-20) that fixes a deadlock between remote-http(s) and
> fetch-pack. I'm not sure if it's the same problem. Jeff  knows more
> about this. The fix is available since v1.8.3

You are more optimistic about my memory than I am. :)

Given the symptoms of the deadlock above, I agree it is a likely culprit. There was a spree of deadlock fixes around the same time, but I think that is the only one that was found on the client side of a fetch.

-Peff