Re: git describe --contains doesn't work properly for a commit

From: Michal Hocko <mhocko@suse.cz>
Date: Feb 26, 2015, 14:23 UTC
Message-ID: <20150226142314.GC14878@dhcp22.suse.cz>
In-Reply-To: <20150226133534.GB14878@dhcp22.suse.cz>

On Thu 26-02-15 14:35:34, Michal Hocko wrote:

Show 8 quoted lines

> Hi,
> I have just encountered an old kernel git commit:
> commit c854363e80b49dd04a4de18ebc379eb8c8806674
> Author: Dave Chinner <david@fromorbit.com>
> Date:   Sat Feb 6 12:39:36 2010 +1100
> 
>     xfs: Use delayed write for inodes rather than async V2
> [...]

 
OK, I've managed to recreate this in a simple repo with 3 commits:
$ git log --format="%H %cd"
ab0efec2b697f2f9f864bb0e2cd77308d1f04561 Thu Feb 26 15:18:36 2015 +0100
d63972e4e4e7eda0444e56739ad09bfbc476b9bd Wed Feb 26 15:18:30 2014 +0100
108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3 Thu Feb 26 14:57:29 2015 +0100

The commit in the middle was ammended to have committer date in the past. $ git describe --contains d63972e4e4e7eda0444e56739ad09bfbc476b9bd tag~1

but $ git describe --contains 108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3 fatal: cannot describe '108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3'

I guess this is the same issue reported previously here: http://git.661346.n2.nabble.com/git-describe-contains-fails-on-given-tree-td5448286.html

Can this be fixed somehow or it would lead to other kind of issues?

-- 
Michal Hocko
SUSE Labs