git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_file.c: make sure open_sha1_file does not open a directory

From
Jeff King <peff@peff.net>
Date
Feb 9, 2015, 01:12 UTC
Message-ID
<20150209011159.GA21072@peff.net>
In-Reply-To
<20150209005444.GA16827@peff.net>
On Sun, Feb 08, 2015 at 07:54:44PM -0500, Jeff King wrote:
Show 6 quoted lines
> However, the first thing for_each_loose_file_in_objdir is going to do is
> stick the path into a strbuf. So perhaps the most sensible thing is to
> just teach it to take a strbuf from the caller. I'll work up a patch.
> 
> It looks like a1b47246 isn't even in "next" yet, so I'll build it
> directly on what is already in master, dropping Jonathan's patch.

Here it is. The first patch is a refactoring to allow this, and the second is the moral equivalent of Jonathon's patch. These replace a1b47246 on the tip of jk/prune-mtime.

  [1/2]: for_each_loose_file_in_objdir: take an optional strbuf path
  [2/2]: sha1_file: fix iterating loose alternate objects
-Peff
Previous: Jeff KingNext: Jeff King
Message 3 of 7 in “sha1_file.c: make sure open_sha1_file does not open a directory”
  1. sha1_file.c: make sure open_sha1_file does not open a directoryKyle J. McKay, Feb 8, 2015
  2. Jeff KingFeb 9, 2015
  3. Jeff KingFeb 9, 2015
  4. 1/2 for_each_loose_file_in_objdir: take an optional strbuf pathJeff King, Feb 9, 2015
  5. 2/2 sha1_file: fix iterating loose alternate objectsJeff King, Feb 9, 2015
  6. Kyle J. McKayFeb 9, 2015
  7. Junio C HamanoFeb 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.