git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] config: do not ungetc EOF

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 8, 2015, 21:13 UTC
Message-ID
<20150208211334.GA3796@book.hvoigt.net>
In-Reply-To
<20150205210024.GA30724@peff.net>
On Thu, Feb 05, 2015 at 04:00:24PM -0500, Jeff King wrote:
Show 14 quoted lines
> On Thu, Feb 05, 2015 at 01:53:27AM -0500, Jeff King wrote:
> 
> > I also notice that config_buf_ungetc does not actually ungetc the
> > character we give it; it just rewinds one character in the stream. This
> > is fine, because we always feed the last-retrieved character. I dunno if
> > it is worth fixing (it also would have fixed this infinite loop, but for
> > the wrong reason; we would have stuck "-1" back into the stream, and
> > retrieved it on the next fgetc rather than the same '\r' over and over).
> 
> Here's a patch to deal with that. I'm not sure if it's worth doing or
> not.
> 
> -- >8 --
> Subject: [PATCH] config_buf_ungetc: warn when pushing back a random character

Thanks for noticing and fixing both. I think it is worth adding this assertion. If someone in the future comes along and uses our fake ungetc() wrong it might save some trouble figuring out whats wrong.

Cheers Heiko
Previous: Heiko Voigt
Message 6 of 6 in “config: do not ungetc EOF”
  1. config: do not ungetc EOFJeff King, Feb 5, 2015
  2. Jeff KingFeb 5, 2015
  3. Junio C HamanoFeb 5, 2015
  4. Jeff KingFeb 5, 2015
  5. Heiko VoigtFeb 8, 2015
  6. Heiko VoigtFeb 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.