git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support

From
Jeff King <peff@peff.net>
Date
Feb 6, 2015, 19:33 UTC
Message-ID
<20150206193349.GB4220@peff.net>
In-Reply-To
<xmqq61bgkt9w.fsf@gitster.dls.corp.google.com>
On Thu, Feb 05, 2015 at 12:17:15PM -0800, Junio C Hamano wrote:
Show 31 quoted lines
> > Would "length() > 1" be enough[1]? Or are people really typing "yes" and
> > not just "y"?
> >
> > I cannot imagine a charset name that is smaller than two characters. It
> > may be that there are none smaller than 4, and we could cut it off
> > there. Googling around for some lists of common charsets, it seems like
> > that might be plausible (but not any larger; "big5" is 4 characters, and
> > people may spell "utf8" without the hyphen).
> >
> > -Peff
> >
> > [1] Of course, to match the existing regex code, we may want to spell
> >     this as "/../" or "/..../".
> 
> Perhaps. Just in case there were shorter ones, something like this
> with confirm_only to allow them to say "Yes, I do mean 'xx'"?
> 
>  git-send-email.perl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 3092ab3..848f176 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -752,6 +752,7 @@ sub file_declares_8bit_cte {
>  		print "    $f\n";
>  	}
>  	$auto_8bit_encoding = ask("Which 8bit encoding should I declare [UTF-8]? ",
> +				  valid_re => qr/.{4}/, confirm_only => 1,
>  				  default => "UTF-8");
>  }
Yes, I think leaving an escape hatch is a good idea, just in case.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 7 in “Re: [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support”
  1. Eric BlakeFeb 5, 2015
  2. Junio C HamanoFeb 5, 2015
  3. Jeff KingFeb 5, 2015
  4. Junio C HamanoFeb 5, 2015
  5. Jeff KingFeb 6, 2015
  6. send-email: ask confirmation if given encoding name is very shortJunio C Hamano, Feb 16, 2015
  7. Jeff KingFeb 18, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.