Re: [PATCH 1/2] t5710-info-alternate: demonstrate bug in unpacked pruning

From: Jeff King <peff@peff.net>
Date: Feb 2, 2015, 17:56 UTC
Message-ID: <20150202175622.GB24025@peff.net>
In-Reply-To: <BF4AA771-DEB5-4DED-9C74-768036C1E2DD@jonathonmah.com>

On Sun, Feb 01, 2015 at 01:55:00PM -0800, Jonathon Mah wrote:

Show 25 quoted lines

> Signed-off-by: Jonathon Mah <me@JonathonMah.com>
> ---
>  t/t5710-info-alternate.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh
> index 5a6e49d..d82844a 100755
> --- a/t/t5710-info-alternate.sh
> +++ b/t/t5710-info-alternate.sh
> @@ -18,6 +18,7 @@ reachable_via() {
>  
>  test_valid_repo() {
>  	git fsck --full > fsck.log &&
> +	git prune &&
>  	test_line_count = 0 fsck.log
>  }
>  
> @@ -47,8 +48,7 @@ test_expect_success 'preparing third repository' \
>  'git clone -l -s B C && cd C &&
>  echo "Goodbye, cruel world" > file3 &&
>  git add file3 &&
> -git commit -m "one more" file3 &&
> -git repack -a -d -l &&
> +git commit -m "one more without packing" file3 &&
>  git prune'

Modifying a test like this makes me a little nervous because now the old test is not checking the same thing (pruning when we are packed), and it's not obvious whether the packing was important to the original test.

And it's not clear that this change is testing a totally unrelated thing. I haven't looked closely, but would it be hard to introduce a new test that more explicitly checks for the breakage?

-Peff