git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: correct --prepare-p4-only instructions

From
PWPete Wyckoff <pw@padd.com>
Date
Jan 23, 2015, 21:39 UTC
Message-ID
<20150123213920.GA3779@padd.com>
In-Reply-To
<1422004512-10049-2-git-send-email-luke@diamand.org>
luke@diamand.org wrote on Fri, 23 Jan 2015 09:15 +0000:
Show 23 quoted lines
> If you use git-p4 with the "--prepare-p4-only" option, then
> it prints the p4 command line to use. However, the command
> line was incorrect: the changelist specification must be
> supplied on standard input, not as an argument to p4.
> 
> Signed-off-by: Luke Diamand <luke@diamand.org>
> ---
>  git-p4.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-p4.py b/git-p4.py
> index ff132b2..90447de 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -1442,7 +1442,7 @@ class P4Submit(Command, P4UserMap):
>              print "  " + self.clientPath
>              print
>              print "To submit, use \"p4 submit\" to write a new description,"
> -            print "or \"p4 submit -i %s\" to use the one prepared by" \
> +            print "or \"p4 submit -i <%s\" to use the one prepared by" \
>                    " \"git p4\"." % fileName
>              print "You can delete the file \"%s\" when finished." % fileName
>  
Looks obviously good here.  Ack!
		-- Pete
Previous: Luke Diamand
Message 3 of 3 in “git-p4: correct --prepare-p4-only instructions”
  1. git-p4: correct --prepare-p4-only instructionsLuke Diamand, Jan 23, 2015
  2. git-p4: correct --prepare-p4-only instructionsLuke Diamand, Jan 23, 2015
  3. Pete WyckoffJan 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.