git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GUILT 1/2] guilt graph: Simplify getfiles.

From
JSJeff Sipek <jeffpc@josefsipek.net>
Date
Jan 23, 2015, 14:36 UTC
Message-ID
<20150123143637.GH101465@meili.jeffnet.31bits.net>
In-Reply-To
<1422022867-7908-2-git-send-email-cederp@opera.com>
Neat.
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
On Fri, Jan 23, 2015 at 03:21:06PM +0100, Per Cederqvist wrote:
Show 25 quoted lines
> git diff-tree by default emits TAB-separated fields.  cut by defaults
> processes TAB-separated fields.  Simplify getfiles() by using TAB as
> the separator.
> 
> Signed-off-by: Per Cederqvist <cederp@opera.com>
> ---
>  guilt-graph | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/guilt-graph b/guilt-graph
> index 0857e0d..d90c2f1 100755
> --- a/guilt-graph
> +++ b/guilt-graph
> @@ -36,7 +36,7 @@ fi
>  
>  getfiles()
>  {
> -	git diff-tree -r "$1^" "$1" | tr '\t' ' ' | cut -d' ' -f6
> +	git diff-tree -r "$1^" "$1" | cut -f2
>  }
>  
>  cache="$GUILT_DIR/$branch/.graphcache.$$"
> -- 
> 2.1.0
> 
-- 
C is quirky, flawed, and an enormous success.
		- Dennis M. Ritchie.
Previous: Per CederqvistNext: Per Cederqvist
Message 3 of 5 in “[GUILT 0/2] Teach "guilt graph" to ignore some files.”
  1. Per CederqvistJan 23, 2015
  2. 1/2 guilt graph: Simplify getfiles.Per Cederqvist, Jan 23, 2015
  3. Jeff SipekJan 23, 2015
  4. 2/2 Teach "guilt graph" the "-x exclude-pattern" option.Per Cederqvist, Jan 23, 2015
  5. Jeff SipekJan 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.