git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GUILT v4 32/33] Improved doc and tests for guilt header.

From
JSJeff Sipek <jeffpc@josefsipek.net>
Date
Jan 22, 2015, 13:56 UTC
Message-ID
<20150122135602.GA101460@meili.jeffnet.31bits.net>
In-Reply-To
<1400450409-30998-33-git-send-email-cederp@opera.com>
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
On Mon, May 19, 2014 at 12:00:08AM +0200, Per Cederqvist wrote:
Show 54 quoted lines
> ---
>  Documentation/guilt-header.txt | 5 ++++-
>  regression/t-028.out           | 9 +++++++++
>  regression/t-028.sh            | 3 +++
>  3 files changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/guilt-header.txt b/Documentation/guilt-header.txt
> index 870bfaf..71b2e66 100644
> --- a/Documentation/guilt-header.txt
> +++ b/Documentation/guilt-header.txt
> @@ -18,7 +18,10 @@ Prints either the topmost patch's header or the header of a specified patch.
>  -E::
>  	Open the raw patch in an editor, instead of printing it.
>  <patchname>::
> -	Name of the patch.
> +	Name of the patch. If a patch with exactly this name exists,
> +	use it. Otherwise, treat the name as a regexp; if the regexp
> +	matches a single patch, use it. Otherwise, list all matching
> +	patch names to stderr and fail.
>  
>  Author
>  ------
> diff --git a/regression/t-028.out b/regression/t-028.out
> index ea72a3a..39ac900 100644
> --- a/regression/t-028.out
> +++ b/regression/t-028.out
> @@ -56,3 +56,12 @@ Patch non-existant is not in the series
>    remove
>    mode
>    patch-with-some-desc
> +% guilt header de
> +de does not uniquely identify a patch. Did you mean any of these?
> +  mode
> +  patch-with-some-desc
> +% guilt header des
> +blah blah blah
> +
> +Signed-off-by: Commiter Name <commiter@email>
> +
> diff --git a/regression/t-028.sh b/regression/t-028.sh
> index 2ce0378..cd3088c 100755
> --- a/regression/t-028.sh
> +++ b/regression/t-028.sh
> @@ -35,4 +35,7 @@ shouldfail guilt header non-existant
>  # patch name is a regexp that just happens to match an existing patch.
>  shouldfail guilt header '.*'
>  
> +shouldfail guilt header de
> +cmd guilt header des
> +
>  # FIXME: how do we check that -e works?
> -- 
> 1.8.3.1
> 
-- 
You measure democracy by the freedom it gives its dissidents, not the
freedom it gives its assimilated conformists.
		- Abbie Hoffman
Previous: Per CederqvistNext: Per Cederqvist
Message 38 of 40 in “[GUILT v4 00/33] Teach guilt import-commit how to create legal patch names, and more”
  1. Per CederqvistMay 18, 2014
  2. 01/33 The tests should not fail if guilt.diffstat is set.Per Cederqvist, May 18, 2014
  3. 02/33 Allow "guilt delete -f" to run from a dir which contains spaces.Per Cederqvist, May 18, 2014
  4. 03/33 Added test case for "guilt delete -f".Per Cederqvist, May 18, 2014
  5. 04/33 Allow "guilt import-commit" to run from a dir which contains spaces.Per Cederqvist, May 18, 2014
  6. 05/33 "guilt new": Accept more than 4 arguments.Per Cederqvist, May 18, 2014
  7. 06/33 Fix the do_get_patch function.Per Cederqvist, May 18, 2014
  8. 07/33 Added test cases for "guilt fold".Per Cederqvist, May 18, 2014
  9. 08/33 Added more test cases for "guilt new": empty patches.Per Cederqvist, May 18, 2014
  10. 09/33 Test suite: properly check the exit status of commands.Per Cederqvist, May 18, 2014
  11. Jeff SipekJan 22, 2015
  12. 10/33 Run test_failed if the exit status of a test script is bad.Per Cederqvist, May 18, 2014
  13. 11/33 test suite: remove pointless redirection.Per Cederqvist, May 18, 2014
  14. 12/33 "guilt header": more robust header selection.Per Cederqvist, May 18, 2014
  15. 13/33 Check that "guilt header '.*'" fails.Per Cederqvist, May 18, 2014
  16. 14/33 Use "git check-ref-format" to validate patch names.Per Cederqvist, May 18, 2014
  17. Jeff SipekJan 22, 2015
  18. 15/33 Produce legal patch names in guilt-import-commit.Per Cederqvist, May 18, 2014
  19. Jeff SipekJan 22, 2015
  20. Per CederqvistJan 22, 2015
  21. 16/33 Fix backslash handling when creating names of imported patches.Per Cederqvist, May 18, 2014
  22. 17/33 "guilt graph" no longer loops when no patches are applied.Per Cederqvist, May 18, 2014
  23. 18/33 guilt-graph: Handle commas in branch names.Per Cederqvist, May 18, 2014
  24. 19/33 Check that "guilt graph" works when working on a branch with a comma.Per Cederqvist, May 18, 2014
  25. 20/33 "guilt graph": Handle patch names containing quotes.Per Cederqvist, May 18, 2014
  26. 21/33 The log.decorate setting should not influence import-commit.Per Cederqvist, May 18, 2014
  27. 22/33 The log.decorate setting should not influence patchbomb.Per Cederqvist, May 18, 2014
  28. 23/33 The log.decorate setting should not influence guilt rebase.Per Cederqvist, May 18, 2014
  29. 24/33 disp no longer processes backslashes.Per Cederqvist, May 18, 2014
  30. 25/33 "guilt push" now fails when there are no more patches to push.Per Cederqvist, May 18, 2014
  31. 26/33 "guilt pop" now fails when there are no more patches to pop.Per Cederqvist, May 18, 2014
  32. 27/33 Minor testsuite fix.Per Cederqvist, May 18, 2014
  33. 28/33 Fix coding style errors in t-061.sh.Per Cederqvist, May 18, 2014
  34. 29/33 Added guilt.reusebranch configuration option.Per Cederqvist, May 18, 2014
  35. 30/33 Added a short style guide, and Emacs settings.Per Cederqvist, May 18, 2014
  36. 31/33 Don't use "git log -p" in the test suite.Per Cederqvist, May 18, 2014
  37. 32/33 Improved doc and tests for guilt header.Per Cederqvist, May 18, 2014
  38. Jeff SipekJan 22, 2015
  39. 33/33 Document the exit status of guilt push and guilt pop.Per Cederqvist, May 18, 2014
  40. Jeff SipekJan 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.