Re: [PATCH] init-db: remove unused #includes

From: Jeff King <peff@peff.net>
Date: Jan 15, 2015, 22:31 UTC
Message-ID: <20150115223112.GB19021@peff.net>
In-Reply-To: <xmqqsifb6atr.fsf@gitster.dls.corp.google.com>

On Thu, Jan 15, 2015 at 12:36:00PM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > FWIW, the full set of CFLAGS I use (which I specify in config.mak) is:
> >
> >     CFLAGS += -Wall -Werror
> >     CFLAGS += -Wno-format-zero-length
> >     CFLAGS += -Wdeclaration-after-statement
> >     CFLAGS += -Wpointer-arith
> >     CFLAGS += -Wstrict-prototypes
> >     CFLAGS += -Wold-style-declaration
> 
> I think I have no-pointer-to-int-cast, old-style-definition and vla
> in addition to the above.

Thanks, I added the latter two to my setup. But what is the purpose of turning off pointer-to-int warnings? It seems like those are a good indication of a sloppy construct (and AFAICT, we do not have any code which triggers on it).

-Peff