Re: [PATCH] git-svn: show progress in working_head_info()
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Jan 10, 2015, 22:21 UTC
- Message-ID
- <20150110222135.GB32253@dcvr.yhbt.net>
- In-Reply-To
- <1420896096-15254-1-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> wrote:
Show 8 quoted lines
> The working_head_info routine takes a very long time to execute on large > repositories. The least we can do is to comfort users that some progress > is being made. > > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > --- > I was worried because of the long wait, so I wrote this to convince > myself that git-svn wasn't stuck.
Unfortunately, this breaks show-ignore and t9101-git-svn-props.sh
show-ignore.expect show-ignore.got differ: char 1, line 1 not ok 23 - test show-ignore
Perhaps output should go to STDERR and also respect $_q?
Show 17 quoted lines
> git-svn.perl | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/git-svn.perl b/git-svn.perl
> index 60f8814..6aa156c 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2022,6 +2022,9 @@ sub working_head_info {
> next;
> }
> next unless s{^\s*(git-svn-id:)}{$1};
> + my $chomped = $_;
> + chomp $chomped;
> + print "[Importing] $chomped\n";
> my ($url, $rev, $uuid) = extract_metadata($_);
> if (defined $url && defined $rev) {
> next if $max{$url} and $max{$url} < $rev;