git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Dec 2014, #05; Mon, 29)

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 5, 2015, 20:06 UTC
Message-ID
<20150105200644.GJ29365@google.com>
In-Reply-To
<CAGZ79kbOnX7LVDB8d2Nw0629MvY+ojmy0kDWATM2Zj8NzPRgjQ@mail.gmail.com>
Stefan Beller wrote:
> On Mon, Dec 29, 2014 at 1:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
>> * sb/copy-fd-errno (2014-11-17) 1 commit
>>  - copy.c: make copy_fd preserve meaningful errno
>>
>>  Will be rerolled as a part of a larger series.
>
> I am not expecting to reroll this as part of a larger series any more.
> So if this makes sense on its own, please pick it up?

I think the errno-based approach is problematic. No callers today run into the problem the patch fixes and if a caller did, I fear that caller would be broken in other ways.

That said, no one seemed too excited about the alternative that propagates the error message more explicitly with a strbuf. I'd be happy to re-send anyway, or I can work around this patch when rerolling.

Thanks, Jonathan

Previous: Stefan BellerNext: Junio C Hamano
Message 6 of 7 in “What's cooking in git.git (Dec 2014, #05; Mon, 29)”
  1. Junio C HamanoDec 29, 2014
  2. Philip OakleyDec 29, 2014
  3. Junio C HamanoDec 30, 2014
  4. Philip OakleyJan 1, 2015
  5. Stefan BellerJan 5, 2015
  6. Jonathan NiederJan 5, 2015
  7. Junio C HamanoJan 7, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.