git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: diff: use built-in patterns by default via git attributes

From
Jeff King <peff@peff.net>
Date
Dec 9, 2014, 20:42 UTC
Message-ID
<20141209204247.GD12001@peff.net>
In-Reply-To
<54875916.7020107@thequod.de>
On Tue, Dec 09, 2014 at 09:18:30PM +0100, Daniel Hahler wrote:
Show 8 quoted lines
> I'm wondering why the built-in patterns (defined in userdiff.c) are not
> being applied by default, e.g. what you would normally do in
> core.attributesfile via:
> 
>     *.py diff=python
> 
> Wouldn't it make sense to provide certain defaults for attributes, where
> Git provides enhanced patterns?
It's been discussed:
  http://thread.gmane.org/gmane.comp.version-control.git/187269

It ended up with a lot of back-and-forth over which extensions belonged to which type, and whether the C funcname pattern was terrible or not. I got sick of it and dropped the patch.

You are welcome to try resurrecting it. :) It might help to read the discussion and drop any contentious names. Since that thread, the C/C++ pattern has improved greatly, so it might not meet so much resistance.

-Peff
Previous: Daniel Hahler
Message 2 of 2 in “diff: use built-in patterns by default via git attributes”
  1. Daniel HahlerDec 9, 2014
  2. Jeff KingDec 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.