git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: propset support v3

From
Alfred Perlstein <alfred@freebsd.org>
Date
Dec 7, 2014, 10:46 UTC
Message-ID
<20141207104628.GA54199@elvis.mu.org>
Added:
Eric Sunshine's:
- suggestion to include the comment about propset only
  working on files with content changes.
Eric Wong's:
- use && to chain commands throughout tests
- use svn_cmd wrapper throughout tests
- show $! in die messages
- favor $(...) over `...` in tests
- make new_props an array simplify building the final list
- wrap long comments (help output still needs fixing)
- remove unnecessary FIXME comment
- commit message improvements.
Torsten Bögershausen:
- Fixes for test cases.

Finally, I have refactored the test cases to reduce duplicate code such that further fixes and improvements can be done in one place.

JFYI, branches are here:
1st review changes:
  https://github.com/splbio/git/compare/master-git-svn-propset-upstream?expand=1
Squashed into:
  https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff?expand=1
Current review in different commits:
  https://github.com/splbio/git/compare/master-git-svn-propset-upstream2?expand=1
Squashed into:
  https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff2?expand=1
  
Thank you very much.
Alfred Perlstein (1):
  git-svn: Support for git-svn propset
 git-svn.perl               | 49 ++++++++++++++++++++++-
 perl/Git/SVN/Editor.pm     | 42 ++++++++++++++++++++
 t/t9148-git-svn-propset.sh | 97 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 187 insertions(+), 1 deletion(-)
 create mode 100755 t/t9148-git-svn-propset.sh
-- 
2.1.2
Message 1 of 1 in “git-svn: propset support v3”
  1. git-svn: propset support v3Alfred Perlstein, Dec 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.