git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

From
Luis Henriques <henrix@camandro.org>
Date
Dec 4, 2014, 19:22 UTC
Message-ID
<20141204192245.GA3386@charon.olymp>
In-Reply-To
<xmqqk328k6ya.fsf@gitster.dls.corp.google.com>
On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote:
Show 29 quoted lines
> Eric Wong <normalperson@yhbt.net> writes:
> 
> > Luis Henriques <henrix@camandro.org> wrote:
> >> On Mon, Mar 24, 2014 at 09:38:27PM +0000, Luis Henriques wrote:
> >> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:'
> >> > header to the email being sent.
> >> >
> >> 
> >> Ping
> >> 
> >> It's been a while since I sent this patch.  Is there any interest in
> >> having this switch in git-send-email?
> >
> > I wasn't paying attention when the original was sent, but this
> > looks good to me.
> >
> > Acked-by: Eric Wong <normalperson@yhbt.net>
> >
> >> I honestly don't like disclosing too much information about my system,
> >> in this case which MUA I'm using and its version.
> >
> > Right on.  I would even favor this being the default.
> >
> > Auto-generated Message-Id headers also shows the use of git-send-email;
> > perhaps there can be a way to configure that, too.  However,
> > git-send-email respects manually-added Message-Id headers in the
> > original patch, so it's less of a problem, I suppose.
> 
> I actually do not think this is a good idea from debuggability.

Do you think this could be merged with yet another switch? I can't think of a name for the switch, something like... "--hide-msgid"?

Another option would be to re-work the --no-xmailer switch to change it into a "--hide-id" (or something), where both the "X-Mailer:" header would be dropped and the Message-id would be obfuscated.

Cheers,
-- 
Luís
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 13 in “send-email: add --[no-]xmailer option”
  1. Luis HenriquesMar 24, 2014
  2. Luis HenriquesDec 2, 2014
  3. Eric WongDec 3, 2014
  4. Kyle J. McKayDec 3, 2014
  5. Luis HenriquesDec 3, 2014
  6. Junio C HamanoDec 3, 2014
  7. Luis HenriquesDec 4, 2014
  8. Junio C HamanoDec 4, 2014
  9. Luis HenriquesDec 4, 2014
  10. Junio C HamanoDec 3, 2014
  11. Junio C HamanoDec 3, 2014
  12. Junio C HamanoDec 3, 2014
  13. Luis HenriquesDec 3, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.