Re: [PATCH/RFC v2] Squashed changes for multiple worktrees vs. submodules

From: Max Kirillov <max@max630.net>
Date: Dec 2, 2014, 22:16 UTC
Message-ID: <20141202221611.GB9128@wheezy.local>
In-Reply-To: <547E24E4.7050100@web.de>

On Tue, Dec 02, 2014 at 09:45:24PM +0100, Jens Lehmann wrote:

Show 19 quoted lines

>> But, while hacking the submodule init I became more
>> convinced that the modules directory should be common and
>> submodules in checkout should be a checkouts of the
>> submodule. Because this is looks like concept of
>> submodules, that they are unique for the lifetime of
>> repository, even if they do not exist in all revisions.
>> And if anybody want to use fully independent checkout
>> they can be always checked out manually. Actually, after
>> a submodule is initialized and have a proper gitlink, it
>> can be updated and inquired regardless of where it points
>> to.
> 
> If I understand you correctly you want to put the
> submodule's common git dir under the superproject's common
> git dir. I agree that that makes most sense as the
> default, but having the possibility to use a common git
> dir for submodule's of different superprojects would be
> nice to have for some setups, e.g. CI-servers. But that
> can be added later.

So far there is no separation of .git/config for different worktrees. As submodules rely on the config their separation cannot be done fully without changing that. So this should be really left for some later improvements.

As a user I am currently perfectly satisfied with manually checking out or even cloning submodules inplace, I don't do it often.

> Thanks. I just didn't quite understand why you had to do so many
> changes to git-submodule.sh. Wouldn't it be sufficient to just
> update module_clone()?

Thanks, I should try it.

Probably I had the opposite idea in mind - keep module_clone as untouched as possible. Maybe I should see how it's going to look if I move all worktrees logic there.

-- 
Max