git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] pre-commit hook updates

From
Jeff King <peff@peff.net>
Date
Nov 26, 2014, 04:52 UTC
Message-ID
<20141126045246.GD15252@peff.net>
In-Reply-To
<cover.1416953772.git.oystwa@gmail.com>
On Tue, Nov 25, 2014 at 11:51:27PM +0100, Øystein Walle wrote:
> I agree with Junio Hamano that it's better to provide no argument at all
> rather than an empty one. I also agree with Jeff King that "noamend" is
> better than an empty argument. I went with the second one since Jeff
> seemed to get the last word :)

I am not sure the last word counts for much. :) We'll see if Junio responds (there, or to your patch). I do not feel _too_ strongly either way, and I don't have much else to say besides what was said.

-Peff
Previous: Eric SunshineNext: Junio C Hamano
Message 11 of 13 in “pre-commit hook updates”
  1. 0/2 pre-commit hook updatesØystein Walle, Nov 25, 2014
  2. 1/2 t7503: use write_script to generate hook scriptsØystein Walle, Nov 25, 2014
  3. Eric SunshineNov 26, 2014
  4. Jeff KingNov 26, 2014
  5. Junio C HamanoNov 26, 2014
  6. Jeff KingNov 26, 2014
  7. Junio C HamanoNov 26, 2014
  8. 2/2 commit: inform pre-commit that --amend was usedØystein Walle, Nov 25, 2014
  9. Eric SunshineNov 26, 2014
  10. Eric SunshineNov 26, 2014
  11. Jeff KingNov 26, 2014
  12. Junio C HamanoNov 26, 2014
  13. Jeff KingNov 26, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.