git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5] lockfile.c: store absolute path

From
SSScott Schmit <i.grok@comcast.net>
Date
Nov 5, 2014, 02:23 UTC
Message-ID
<20141105022315.GA28292@odin.ulthar.us>
In-Reply-To
<1414909477-20030-1-git-send-email-mhagger@alum.mit.edu>
On Sun, Nov 02, 2014 at 07:24:37AM +0100, Michael Haggerty wrote:
Show 17 quoted lines
> Locked paths can be saved in a linked list so that if something wrong
> happens, *.lock are removed. For relative paths, this works fine if we
> keep cwd the same, which is true 99% of time except:
> 
> - update-index and read-tree hold the lock on $GIT_DIR/index really
>   early, then later on may call setup_work_tree() to move cwd.
> 
> - Suppose a lock is being held (e.g. by "git add") then somewhere
>   down the line, somebody calls real_path (e.g. "link_alt_odb_entry"),
>   which temporarily moves cwd away and back.
> 
> During that time when cwd is moved (either permanently or temporarily)
> and we decide to die(), attempts to remove relative *.lock will fail,
> and the next operation will complain that some files are still locked.
> 
> Avoid this case by turning relative paths to absolute before storing
> the path in "filename" field.

This might be a little pathological, but it seems like this scheme would run into trouble if the entire repo is moved while the lock is held.

Previous: Michael HaggertyNext: Michael Haggerty
Message 2 of 3 in “lockfile.c: store absolute path”
  1. lockfile.c: store absolute pathMichael Haggerty, Nov 2, 2014
  2. Scott SchmitNov 5, 2014
  3. Michael HaggertyNov 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.