Re: [PATCH] fetch-pack: don't resend known-common refs in find_common

From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date: Oct 26, 2014, 15:42 UTC
Message-ID: <20141026154241.GB28288@spirit>
In-Reply-To: <CACsJy8B7nOZCjdF_hki5amv-uCY17hz59oPDvx-ufbRrdvTweQ@mail.gmail.com>

On Wed, Oct 22, 2014 at 05:07:31PM +0700, Duy Nguyen wrote:

Show 11 quoted lines

> On Wed, Oct 22, 2014 at 2:41 PM, Dennis Kaarsemaker
> <dennis@kaarsemaker.net> wrote:
> > I see two options:
> >
> > * Turning that interaction into a more cooperative process, with a
> >   select/poll loop
> > * Make upload-pack buffer its entire response when run in stateless_rpc
> >   mode until it has consumed all of the request
> 
> Or add a helper daemon and support stateful smart http. Or maybe
> that's what you meant in the first option.

No, I meant that get-http-backend should have a select/poll loop that can read from and write to git-upload-pack at the same time, but option two was easier to implement :)

Stateful smart http seems to be against the design goals of smart http if I interpret Documentation/technical/http-protocol.txt correctly though, so that doesn't seem to be the right approach.

-- 
Dennis Kaarsemaker <dennis@kaarsemaker.net>
http://twitter.com/seveas