git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v16 06/11] trailer: put all the processing together and print

From
Christian Couder <chriscool@tuxfamily.org>
Date
Oct 13, 2014, 18:16 UTC
Message-ID
<20141013181634.27329.50950.chriscool@tuxfamily.org>
In-Reply-To
<20141013181428.27329.86081.chriscool@tuxfamily.org>

This patch adds the process_trailers() function that calls all the previously added processing functions and then prints the results on the standard output.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 trailer.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 trailer.h |  6 ++++++
 2 files changed, 75 insertions(+)
 create mode 100644 trailer.h
diff --git a/trailer.c b/trailer.c
index 4f0de3b..b0be0d7 100644
--- a/trailer.c
+++ b/trailer.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "string-list.h"
+#include "trailer.h"
 /*
  * Copyright (c) 2013, 2014 Christian Couder <chriscool@tuxfamily.org>
  */
@@ -87,6 +88,35 @@ static void free_trailer_item(struct trailer_item *item)
 	free(item);
 }
 
+static char last_non_space_char(const char *s)
+{
+	int i;
+	for (i = strlen(s) - 1; i >= 0; i--)
+		if (!isspace(s[i]))
+			return s[i];
+	return '\0';
+}
+
+static void print_tok_val(const char *tok, const char *val)
+{
+	char c = last_non_space_char(tok);
+	if (!c)
+		return;
+	if (strchr(separators, c))
+		printf("%s%s\n", tok, val);
+	else
+		printf("%s%c %s\n", tok, separators[0], val);
+}
+
+static void print_all(struct trailer_item *first, int trim_empty)
+{
+	struct trailer_item *item;
+	for (item = first; item; item = item->next) {
+		if (!trim_empty || strlen(item->value) > 0)
+			print_tok_val(item->token, item->value);
+	}
+}
+
 static void update_last(struct trailer_item **last)
 {
 	if (*last)
@@ -697,3 +727,42 @@ static int process_input_file(struct strbuf **lines,
 
 	return patch_start;
 }
+
+static void free_all(struct trailer_item **first)
+{
+	while (*first) {
+		struct trailer_item *item = remove_first(first);
+		free_trailer_item(item);
+	}
+}
+
+void process_trailers(const char *file, int trim_empty, struct string_list *trailers)
+{
+	struct trailer_item *in_tok_first = NULL;
+	struct trailer_item *in_tok_last = NULL;
+	struct trailer_item *arg_tok_first;
+	struct strbuf **lines;
+	int patch_start;
+
+	/* Default config must be setup first */
+	git_config(git_trailer_default_config, NULL);
+	git_config(git_trailer_config, NULL);
+
+	lines = read_input_file(file);
+
+	/* Print the lines before the trailers */
+	patch_start = process_input_file(lines, &in_tok_first, &in_tok_last);
+
+	arg_tok_first = process_command_line_args(trailers);
+
+	process_trailers_lists(&in_tok_first, &in_tok_last, &arg_tok_first);
+
+	print_all(in_tok_first, trim_empty);
+
+	free_all(&in_tok_first);
+
+	/* Print the lines after the trailers as is */
+	print_lines(lines, patch_start, INT_MAX);
+
+	strbuf_list_free(lines);
+}
diff --git a/trailer.h b/trailer.h
new file mode 100644
index 0000000..8eb25d5
--- /dev/null
+++ b/trailer.h
@@ -0,0 +1,6 @@
+#ifndef TRAILER_H
+#define TRAILER_H
+
+void process_trailers(const char *file, int trim_empty, struct string_list *trailers);
+
+#endif /* TRAILER_H */
-- 
2.1.0.rc0.248.gb91fdbc
Previous: Christian CouderNext: Christian Couder
Message 7 of 12 in “Add interpret-trailers builtin”
  1. 00/11 Add interpret-trailers builtinChristian Couder, Oct 13, 2014
  2. 01/11 trailer: add data structures and basic functionsChristian Couder, Oct 13, 2014
  3. 02/11 trailer: process trailers from input message and argumentsChristian Couder, Oct 13, 2014
  4. 03/11 trailer: read and process config informationChristian Couder, Oct 13, 2014
  5. 04/11 trailer: process command line trailer argumentsChristian Couder, Oct 13, 2014
  6. 05/11 trailer: parse trailers from file or stdinChristian Couder, Oct 13, 2014
  7. 06/11 trailer: put all the processing together and printChristian Couder, Oct 13, 2014
  8. 07/11 trailer: add interpret-trailers commandChristian Couder, Oct 13, 2014
  9. 08/11 trailer: add tests for "git interpret-trailers"Christian Couder, Oct 13, 2014
  10. 09/11 trailer: execute command from 'trailer.<name>.command'Christian Couder, Oct 13, 2014
  11. 10/11 trailer: add tests for commands in config fileChristian Couder, Oct 13, 2014
  12. 11/11 Documentation: add documentation for 'git interpret-trailers'Christian Couder, Oct 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.