Re: project wide: git config entry for [diff] renames=true

From: Jeff King <peff@peff.net>
Date: Sep 25, 2014, 18:00 UTC
Message-ID: <20140925180005.GA11755@peff.net>
In-Reply-To: <1411660111.4026.24.camel@joe-AO725>

On Thu, Sep 25, 2014 at 08:48:31AM -0700, Joe Perches wrote:

Show 16 quoted lines

> On Thu, 2014-09-25 at 17:03 +0200, Greg Kroah-Hartman wrote:
> 
> > In the future, please generate a git "move" diff, which makes it easier
> > to review, and prove that nothing really changed.  It also helps if the
> > file is a bit different from what you diffed against, which in my case,
> > was true.
> 
> Maybe it'd be possible to add 
> 
> [diff]
> 	renames = true
> 
> to the .git/config file.
> 
> but I don't find a mechanism to add anything to the
> .git/config and have it be pulled.

There is no such mechanism within git. We've resisted adding one because of the danger of something like:

  [diff]
    external = rm -rf /

diff.renames is probably safe, but any config-sharing mechanism would have to deal with either whitelisting, or providing some mechanism for the puller to review changes before blindly following them.

-Peff