git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] fsck: do not canonicalize modes in trees we are checking

From
Edward Thomson <ethomson@edwardthomson.com>
Date
Sep 23, 2014, 16:23 UTC
Message-ID
<20140923162343.GA20379@debian>
In-Reply-To
<20140923154751.GA19319@peff.net>
On Tue, Sep 23, 2014 at 11:47:51AM -0400, Jeff King wrote:
> As far as I can tell, fsck's mode-checking has been totally broken
> basically forever. Which makes me a little nervous to fix it. :)
> linux.git does have some bogus modes, but they are 100664, which is
> specifically ignored here unless "fsck --strict" is in effect.

I'm in favor of checking the mode in fsck, at least when --strict. But I would suggest we be lax (by default) about other likely-to-exist but strictly invalid modes to prevent peoples previously workable repositories from being now broken.

I have, for example, encountered 100775 in the wild, and would argue that like 100644, it should probably not fail unless we are in --strict mode.

Thanks- -ed

Previous: Jeff KingNext: Jeff King
Message 2 of 8 in “fsck: do not canonicalize modes in trees we are checking”
  1. fsck: do not canonicalize modes in trees we are checkingJeff King, Sep 23, 2014
  2. Edward ThomsonSep 23, 2014
  3. Jeff KingSep 23, 2014
  4. Ben AvelingOct 12, 2014
  5. Jeff KingOct 14, 2014
  6. Jeff KingOct 16, 2014
  7. Ben AvelingOct 19, 2014
  8. Jeff KingOct 20, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.