Re: [PATCH v5 12/35] prepare_index(): declare return value to be (const char *)

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 16, 2014, 21:17 UTC
Message-ID: <20140916211709.GM29050@google.com>
In-Reply-To: <1410896036-12750-13-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

Show 10 quoted lines

> Declare the return value to be const to make it clear that we aren't
> giving callers permission to write over the string that it points at.
> (The return value is the filename field of a struct lock_file, which
> can be used by a signal handler at any time and therefore shouldn't be
> tampered with.)
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  builtin/commit.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

I wonder if we should just bite the bullet and make lock_file an opaque struct with accessors for int fd and const char *filename.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.