Re: [PATCH 4/8] staging: et131x: Remove ununsed statistics

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Sep 13, 2014, 19:41 UTC
Message-ID: <20140913194134.GF6549@mwanda>
In-Reply-To: <20140913154556.GA12361@kroah.com>

On Sat, Sep 13, 2014 at 08:45:56AM -0700, Greg KH wrote:

Show 16 quoted lines

> On Sat, Sep 13, 2014 at 12:37:46PM +0300, Dan Carpenter wrote:
> > On Thu, Sep 11, 2014 at 10:59:42PM +0100, Mark Einon wrote:
> > > >From struct ce_stats; unicast_pkts_rcvd, unicast_pkts_xmtd,
> > > multicast_pkts_xmtd, broadcast_pkts_rcvd and broadcast_pkts_xmtd
> > 
> > For some reason something adds a '>' to the start of lines which start
> > with 'From'.  I don't know what it is...
> 
> It's an email protocol requirement, some RFC dictates it as "From" at
> the start of the line is an email "start" flag.
> 
> > When I apply this patch with 'git am' then it just removes the From
> > line.
> 
> As it should :)
>

But now the changelog is corrupt. I have tested with the git version 2.1.0.238.gce1d3a9. The first line of the changelog gets chopped off because of the ">From".

It's a little annoying. Do we just tell Mark to resend with a different changelog or is there a way to fix the tools?

regards, dan carpenter