git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] make config --add behave correctly for empty and NULL values

From
Jeff King <peff@peff.net>
Date
Sep 12, 2014, 02:29 UTC
Message-ID
<20140912022945.GB15519@peff.net>
In-Reply-To
<xmqqy4tpbuii.fsf@gitster.dls.corp.google.com>
On Thu, Sep 11, 2014 at 04:35:33PM -0700, Junio C Hamano wrote:
Show 21 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > Here is the patch I wrote, for reference (I also think breaking the
> > "matches" function into a series of conditionals, as you showed, is way
> > more readable):
> 
> OK, while reviewing the today's issue of "What's cooking" and making
> topics graduate to 'master', I got annoyed that the bottom of jch
> branch still needed to be kept.  Let's do this.
> 
> -- >8 --
> From: Jeff King <peff@peff.net>
> Date: Tue, 19 Aug 2014 02:20:00 -0400
> Subject: [PATCH] config: avoid a funny sentinel value "a^"
> 
> Introduce CONFIG_REGEX_NONE as a more explicit sentinel value to say
> "we do not want to replace any existing entry" and use it in the
> implementation of "git config --add".
> 
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looks good, and adding my signoff is fine. Thanks.
-Peff
Previous: Junio C HamanoNext: Tanay Abhra
Message 8 of 12 in “make config --add behave correctly for empty and NULL values”
  1. make config --add behave correctly for empty and NULL valuesTanay Abhra, Aug 18, 2014
  2. Matthieu MoyAug 18, 2014
  3. Junio C HamanoAug 18, 2014
  4. Jeff KingAug 19, 2014
  5. Junio C HamanoAug 19, 2014
  6. Jeff KingAug 19, 2014
  7. Junio C HamanoSep 11, 2014
  8. Jeff KingSep 12, 2014
  9. 1/2 document irregular config --add behaviour for empty and NULL valuesTanay Abhra, Sep 12, 2014
  10. 2/2 make config --add behave correctly for empty and NULL valuesTanay Abhra, Sep 12, 2014
  11. Matthieu MoySep 12, 2014
  12. Junio C HamanoSep 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.