Re: [PATCH 4/6] fsck: check tag objects' headers

From: Jeff King <peff@peff.net>
Date: Sep 4, 2014, 02:04 UTC
Message-ID: <20140904020454.GB32310@peff.net>
In-Reply-To: <xmqq7g1kwb39.fsf@gitster.dls.corp.google.com>

On Wed, Sep 03, 2014 at 04:14:34PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > The main advantage of the "tag" field is that it is machine-readable,
> > and that your verification process can check that "git verify-tag
> > v2.1.0" actually returns a tag that says "tag v2.1.0". But I do not
> > think we do that verification at all. I wonder if that is something we
> > should add support for.
> 
> Yes.  That essentially boils down to "refs/tags/$tag" must have "tag $tag"
> line (the reverse may not have to be true if the hierarchy is
> outside refs/tags/, though).

Exactly. But to just bring it back to the original series, I do not think this is a thing that fsck should care about. It is something that verify-tag should care about (but again, not unconditionally, and probably not by default).

-Peff